Indentation, require work to adjust whitespace, but are trivial to fix.įeedback on these patches and proposed changes welcome, as always.īuild: correct indentation in list of libsīuild: simplify the driver build configuration fileīuild: reduce indentation in app build specīuild: reduce indentation in examples build specīuild: change infrastructure file tabs to spacesĭrivers: change meson file tabs to spacesĮxamples: change meson file tabs to spaces No more difficult than it would otherwise be. * More work involved in backports - though with the more complicated mesonīlocks changing whitespace levels anyway due to #1 and #2 above, it's probably * Outstanding patches for meson would need respin Programming, this is a possible issue with meson compared to C or Python,īecause we cannot create separate functions to move inner loops to lower NOTE: While not normally a consideration in * Align with official meson style, used on other projects Here are the arguments for/against, as I see them. We are to ever change, I believe it should be now while other rework such as The correct meson style using spaces, but sadly it was not done that way. Implementation of meson build for DPDK should have originally been done using Of these changes, I expect #3 to be most controversial. Work is needed to expand this list in future. Libs, all of which are safe because they are not buildable on FreeBSD. Include in this an explicit list of libraries which are Add a "disable_libs" build option to allow the user to optionally not buildĬertain components. While as usefulĬleanup, the main driver for this was that it simplifies the matching for #5ĥ. Remove the "librte_" prefix from all our library directories. Meson files from that of C-files using tabs, to Meson/Python style using Whitespace changes, take the opportunity to switch our indentation style for Since the larger blocks of meson code in our repo is seeing massive Similarly reduces indentation levels and makes the code easier to followģ. For libraries, drop support for header-only libraries, which was added justįor the "compat" lib which had a single header, and is now part of EAL. In the foreach loops when building library or driver components.Ģ. Use "continue" keyword, new in 0.49 to shorten and reduce indentation levels Updates all assume that the minimum version for DPDK has increased to at leastġ. This RFC contains 5 changes/updates to the DPDK build and build files. To: dev +Cc: thomas, david.marchand, bluca, Bruce Richardson ` (17 more replies) 0 siblings, 18 replies 71+ messages in threadįrom: Bruce Richardson 11:49 UTC ( / raw) 11:49 ` editorconfig: add entry for meson files Bruce Richardson Build file update proposals All of help / color / mirror / Atom feed * Build file update proposals 11:49 Bruce Richardson
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |